drop luarocks in favour of rover #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
rover
branch
2 times, most recently
from
0930509 to
55e4b85
Compare
* rover is now the only supported option * unify paths in builder/runtime image * env is configured to load rover dependencies
so template-less nginx can have a stable path for those
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Oct 23, 2017
* new rover integration 3scale/s2i-openresty#38 * builder and runtime images have the same path `/opt/app-root/src` * apicast can start without a prefix, using default openresty prefix
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Oct 25, 2017
* new rover integration 3scale/s2i-openresty#38 * builder and runtime images have the same path `/opt/app-root/src` * apicast can start without a prefix, using default openresty prefix
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Oct 25, 2017
* new rover integration 3scale/s2i-openresty#38 * builder and runtime images have the same path `/opt/app-root/src` * apicast can start without a prefix, using default openresty prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for 3scale/APIcast#449, builds on #37
applications should have proper ENV that contains rover dependencies
also no need to install dependencies from rockspecs when rover lock is there
this PR drops luarocks binary in favour of rover, so it won't automatically install dependencies from rockspecs anymore
also unify the source path on
/opt/app-root/srcas other s2i builders.