Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua port of benchmark-ips #707

Merged
merged 1 commit into from
May 30, 2018
Merged

lua port of benchmark-ips #707

merged 1 commit into from
May 30, 2018

Conversation

mikz
Copy link
Contributor

@mikz mikz commented May 14, 2018

Warming up --------------------------------------
                 ffi
    708409 i/100ms

             syscall
    593019 i/100ms

Calculating -------------------------------------
 11385724.4 (±1.9%) i/s -   57381129 in   5.041731s
 10427682.8 (±1.0%) i/s -   52185672 in   5.005021s

It ports awesome https://github.com/evanphx/benchmark-ips to Lua.
The idea is that we have clear benchmarks for some constructs that can show performance difference.
I could see some LuaJIT features like turning off JIT for some functions to see the impact of JIT on performance.

You can see benchmark results in #714 (comment)

@mikz mikz force-pushed the lua-benchmark branch from e808bb6 to ff04f55 Compare May 28, 2018 17:35
@mikz mikz changed the title [wip] lua port of benchmark-ips lua port of benchmark-ips May 28, 2018
@mikz mikz force-pushed the lua-benchmark branch from ff04f55 to 138cb8a Compare May 28, 2018 17:43
@mikz mikz requested a review from davidor May 28, 2018 17:48
return after - before
end

-- Add one second to the time represenetation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds s seconds.

Copy link
Contributor

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🏅

Have you thought about extracting this into its own lib? It'd be useful outside APIcast too.

@mikz
Copy link
Contributor Author

mikz commented May 30, 2018

@davidor yep, but when we get some milage on this.

Warming up --------------------------------------
                 ffi
    708409 i/100ms

             syscall
    593019 i/100ms

Calculating -------------------------------------
 11385724.4 (±1.9%) i/s -   57381129 in   5.041731s
 10427682.8 (±1.0%) i/s -   52185672 in   5.005021s
@mikz mikz force-pushed the lua-benchmark branch from 138cb8a to 018605c Compare May 30, 2018 09:55
@mikz mikz merged commit 0504cc2 into master May 30, 2018
@mikz mikz deleted the lua-benchmark branch May 30, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants