-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[THREESCALE-9510] Allow JWT Claim Check policy access to full request context when evaluate condition #1535
[THREESCALE-9510] Allow JWT Claim Check policy access to full request context when evaluate condition #1535
Conversation
be5bb77
to
c06d415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification steps working.
LGTM
Not approved due to some comments I want to clarify on the doc side.
"resource": "/resource", | ||
"resource_type": "plain" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
], | |
"enable_extended_context": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
"resource": "/resource", | ||
"resource_type": "plain" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
], | |
"enable_extended_context": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
} | ||
``` | ||
|
||
NOTE: when `enable_extended_context` is set, JWT claim value is access via `jwt` prefix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only for liquid templating, isn't it? when plain
templating is used, jwt.
prefix is being added by the gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right. I updated the readme
What
Fix https://issues.redhat.com/browse/THREESCALE-9510
Verification steps
apicast-config.json
as followHTTP/1.1 200 OK
role=default-roles-basic3
HTTP/1.1 403 Forbidden
should be returned