Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest releases #1372

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Latest releases #1372

merged 3 commits into from
Aug 17, 2022

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Aug 17, 2022

what

  • CHANGELOG.md: updated
  • gateway/src/apicast/version.lua set to latest. It should be updated accordingly in release branches

@eguzki eguzki requested a review from a team as a code owner August 17, 2022 12:42
kevprice83
kevprice83 reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@kevprice83 kevprice83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of specifying latest? Doesn't that mean every release will print latest? Having the specific versions is quite handy when troublshooting and we want to quickly refer to the version.

@eguzki
Copy link
Member Author

eguzki commented Aug 17, 2022

version should be updated accordingly in release branches.

@eguzki eguzki merged commit 93c66b9 into master Aug 17, 2022
@eguzki eguzki deleted the latest-releases branch August 17, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevprice83 kevprice83 kevprice83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @kevprice83