Threescale 7967 http proxy patch #1323
Conversation
| @@ -1,10 +1,10 @@ | |||
| # Change Log | |||
|
|
|||
There was a problem hiding this comment.
were all these newlines and formatting changes in the CHANGELOG meant to be committed?
There was a problem hiding this comment.
no I didn't make those changes, not sure where they came from to be honest. I only added a CHANGELOG entry, I assume you are referring to the CHANGELOG and not README though right?
There was a problem hiding this comment.
yes I was :) - fixed my comment
| return httpc | ||
| elseif uri.scheme == 'https' and skip_https_connect then | ||
| request.path = format('%s://%s:%s%s', uri.scheme, host, port, request.path or '/') | ||
| return _connect_tls_direct(httpc, request, host, port) | ||
| request.path = format('%s://%s:%s%s', uri.scheme, uri.host, uri.port, request.path or '/') |
There was a problem hiding this comment.
I think that this will work, but please test this with routing policy, I remember that we had issues with that. Also, with Camel policy
There was a problem hiding this comment.
I will check with the routing policy yep! However, the camel policy I might need to get some help with because I don't understand how that works and the tests for that specific policy are not passing even without my changes. It seems like something is broken there or maybe it's expected and we need to test in another way?
|
@samugi I've pushed the first iteration of a fix for the upstream http problem but there is a definite issue to take care of with args and so tests 13, 15 & 16 are partially failing as a result. Let's try to fix that last item on Tuesday. |
kevprice83
force-pushed
the
THREESCALE-7967-http-proxy-patch
branch
from
9b6d442 to
97c0c46
Compare
kevprice83
changed the title
samugi
force-pushed
the
THREESCALE-7967-http-proxy-patch
branch
from
9cf3bad to
83c551d
Compare
…ct request adds comments linking to RFC and defines host and port values to remaining conditions adds CHANGELOG entry patches http proxy upstream requests adds comments for future refactor
fixed integration tests from 10 to 20 Signed-off-by: Samuele Illuminati <[email protected]> fixes integration tests & adds upstream http proxy patch fixes integration & unit tests
…commit 97c0c46 & adds back repeat_each(3) in integration test
eguzki
force-pushed
the
THREESCALE-7967-http-proxy-patch
branch
from
83c551d to
4b47c81
Compare
I will leave this as marked WIP until we are able to safely merge to master again in the future. This PR is an example for the new, temporary patch process discussed with the 3scale program.
Fixes THREESCALE-7967