Policy: rate limit headers does not send invalid value. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Jun 30, 2020
| @@ -55,9 +55,22 @@ local function decrement(self, usage) | |||
| return self.cache:decrement_usage_metric(usage) | |||
| end | |||
|
|
|||
| -- return 0 if the number is negative | |||
| local function positive_number(number) | |||
| if tonumber(number) <= 0 then | |||
There was a problem hiding this comment.
return math.max(tonumber(number), 0)?
| local function add_headers(info) | ||
| ngx.header[limit_header] = info.limit | ||
| ngx.header[remaining_header] = info.remaining | ||
| ngx.header["eloy"] = "test" |
davidor
approved these changes
Jul 2, 2020
When the backend does not reply with limit headers, APIcast should send no limit headers at all. This change make sure that the value is not send at all. Also, make sure that the value of limit and reset is always positive or 0. THREESCALE-3795 Signed-off-by: Eloy Coto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the backend does not reply with limit headers, APIcast should send
no limit headers at all. This change make sure that the value is not
send at all.
Also, make sure that the value of limit and reset is always positive or
0.
THREESCALE-3795
Signed-off-by: Eloy Coto [email protected]