Policy: MTLS upstream policy #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
UPstreamTLS
branch
2 times, most recently
from
240b79b to
2f6b062
Compare
|
This PR should be reviewed with this PR: |
eloycoto
force-pushed
the
UPstreamTLS
branch
4 times, most recently
from
378b601 to
81f40dc
Compare
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
porueesq
reviewed
Apr 3, 2020
davidor
reviewed
Apr 3, 2020
There was a problem hiding this comment.
I can't comment on 3scale/apicast-nginx-module#1 because I'm not familiar with the code base. I trust you with that :)
This PR looks good 👍
| { | ||
| "$schema": "http://apicast.io/policy-v1.1/schema#manifest#", | ||
| "name": "Upstream MTLS", | ||
| "summary": "foo", |
| "$schema": "http://apicast.io/policy-v1.1/schema#manifest#", | ||
| "name": "Upstream MTLS", | ||
| "summary": "foo", | ||
| "description": "foo", |
porueesq
approved these changes
Apr 6, 2020
By default, at the moment if a user wants to use MTLS with the upstream API, the only way is using `APICAST_PROXY_SSL_CERTIFICATE`, and this certificate will be used in all services. With this policy, that includes an Nginx patch, and a new Nginx-module, different client certificates can be used by service, so one APICast instance can host more than MTLS connections to different upstreams. Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
With the update, exclusiveM* functions are now checked and some unit tests failed due to invalid data. Also set window to min 0, because test: `TEST 22: Window is set to 0 and default is 1.` is already checking this. Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
Co-Authored-By: porueesq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, at the moment if a user wants to use MTLS with the upstream
API, the only way is using
APICAST_PROXY_SSL_CERTIFICATE, and thiscertificate will be used in all services.
With this policy, that includes an Nginx patch, and a new Nginx-module,
different client certificates can be used by service, so one APICast
instance can host more than MTLS connections to different upstreams.
Signed-off-by: Eloy Coto [email protected]