-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Openresty to 1.15.8.1 version #1049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
824c930
to
34a4d09
Compare
mikz
reviewed
May 30, 2019
e7d2a72
to
001f451
Compare
mikz
approved these changes
Jun 3, 2019
davidor
reviewed
Jun 3, 2019
@@ -1,3 +1,5 @@ | |||
getmetatable(_G).__newindex = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment explaining why this is needed 🙏
Looks good to me apart from the missing comment 👍 |
Signed-off-by: Eloy Coto <[email protected]>
Due to the update on the image the ssl library return 0 instead of error. Signed-off-by: Eloy Coto <[email protected]>
Due to the changes in openresty, ngx.ctx can trigger an error [0], to avoid errors on different phases called ngx.ctx using pcall and validate that the return value is a table. Signed-off-by: Eloy Coto <[email protected]>
To make this helper available to other test. Signed-off-by: Eloy Coto <[email protected]>
ngx_now is imported by resty, so the expired_in is the current unixtime. This validate that cache values are correct. Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
davidor
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eloy Coto [email protected]