Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Openresty to 1.15.8.1 version #1049

Merged
merged 6 commits into from
Jun 3, 2019
Merged

Conversation

eloycoto
Copy link
Contributor

Signed-off-by: Eloy Coto [email protected]

@eloycoto eloycoto requested a review from a team as a code owner May 29, 2019 09:20
@eloycoto eloycoto force-pushed the OpenrestyUpdate branch 3 times, most recently from 824c930 to 34a4d09 Compare May 30, 2019 07:12
@eloycoto eloycoto force-pushed the OpenrestyUpdate branch 6 times, most recently from e7d2a72 to 001f451 Compare June 3, 2019 10:14
@eloycoto eloycoto changed the title WIP: Testing new openresty version container Bump Openresty to 1.15.8.1 version Jun 3, 2019
@eloycoto eloycoto requested a review from mikz June 3, 2019 10:23
@@ -1,3 +1,5 @@
getmetatable(_G).__newindex = nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why this is needed 🙏

@davidor
Copy link
Contributor

davidor commented Jun 3, 2019

Looks good to me apart from the missing comment 👍

eloycoto added 6 commits June 3, 2019 14:14
Due to the update on the image the ssl library return 0 instead of
error.

Signed-off-by: Eloy Coto <[email protected]>
Due to the changes in openresty, ngx.ctx can trigger an error [0], to
avoid errors on different phases called ngx.ctx using pcall and validate
that the return value is a table.

Signed-off-by: Eloy Coto <[email protected]>
To make this helper available to other test.

Signed-off-by: Eloy Coto <[email protected]>
ngx_now is imported by resty, so the expired_in is the current unixtime.
This validate that cache values are correct.

Signed-off-by: Eloy Coto <[email protected]>
@eloycoto eloycoto requested a review from davidor June 3, 2019 12:15
@davidor davidor merged commit 6e4d637 into 3scale:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants