[THREESCALE-1692] Change schema of IP check policy so it renders correctly in the UI #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
approved these changes
May 3, 2019
This is just because of how the react-jsonschema-form library renders an array with uniqueItems=true. It turns out that it renders a multiple selection box, but it does not allow to sort its elements. The original intention of the policy was to allow sorting those elements to try them in the selected order. Deleting uniqueItems=true solves the issue. However, now it's possible to add duplicates in the array but it does not really affect the behavior of the policy.
With the change introduced in the schema in the previous commit, there might be duplicated sources. This test checks that the policy works well when there are duplicates.
davidor
force-pushed
the
fix-ip-check-policy
branch
from
5a56b98 to
bdef0b1
Compare
|
Rebased to solve the conflicts in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #970 and THREESCALE-1692