[THREESCALE-2205] Fix incorrect connection reuse #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://issues.jboss.org/browse/THREESCALE-2205 By default, the 'connect' method of lua-resty-http, uses the ip and the host as the key to find a connection in the pool of idle connections. Ref: https://github.com/ledgetech/lua-resty-http#connect That can cause problems in the case of HTTPS requests as mentioned in the issue linked above. For example, when 2 different domains resolve to the same IP, the connection is reused, and it should not be. The 'connect_proxy' method of the modified module was using correct IDs for the pool, but the 'connect_direct' method was not.
mikz
approved these changes
Apr 25, 2019
|
/cc @mayorova |
|
Awesome, thanks @davidor :) |
davidor
added a commit
that referenced
this pull request
May 7, 2019
[THREESCALE-2205] Fix incorrect connection reuse
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.jboss.org/browse/THREESCALE-2205
By default, the 'connect' method of lua-resty-http, uses the ip and the host as the key to find a connection in the pool of idle connections. Ref: https://github.com/ledgetech/lua-resty-http#connect
That can cause problems in the case of HTTPS requests as mentioned in the issue linked above. For example, when 2 different domains resolve to the same IP, the connection is reused, and it should not be.
The 'connect_proxy' method of the modified module was using correct IDs for the pool, but the 'connect_direct' method was not.