[oidc] do not useaud JWT claim [THREESCALE-2263]
#1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
oidc-aud-check
branch
2 times, most recently
from
f1a23dc to
96f7768
Compare
davidor
reviewed
Apr 3, 2019
| @@ -91,7 +91,7 @@ function _M:get_all(service_id) | |||
|
|
|||
| local report = keys_helper.report_from_key_batched_report(key, value) | |||
|
|
|||
| if value and value > 0 and report.service_id == service_id then | |||
| if value and value > 0 and report and report.service_id == service_id then | |||
There was a problem hiding this comment.
I think that the failing test was because of this:
APIcast/t/apicast-policy-3scale-batcher.t
Line 613 in e825115
azp => "appid".
There was a problem hiding this comment.
Yes, but still report_from_key_batched_report can return nil and this will crash. That should not happen.
There was a problem hiding this comment.
Yes, that too. I think that apart from that, we should add a warning in report_from_key_batched_report, because if it returns nil, it means that the policy received a combination of "auth params" (app_id, app_key, ...) that it's not supported.
There was a problem hiding this comment.
That probably deserves its own PR with a test. Will create one.
mikz
force-pushed
the
oidc-aud-check
branch
2 times, most recently
from
c4726ae to
50d7e6d
Compare
mikz
changed the title
aud JWT claimaud JWT claim [THREESCALE-2263]
it might not contain client_id, so better not to use it #988 (comment)
davidor
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it might not contain client_id, so better not to use it
#988 (comment)