Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of APIcast parameter : APICAST_SERVICES_FILTER_BY_URL #1069

Open
metaversed opened this issue Jun 13, 2019 · 2 comments
Open

Description of APIcast parameter : APICAST_SERVICES_FILTER_BY_URL #1069

metaversed opened this issue Jun 13, 2019 · 2 comments

Comments

@metaversed
Copy link

[provide a description of the issue]
APIcast parameter : APICAST_SERVICES_FILTER_BY_URL

Description

Used to filter the service configured in the 3scale API Manager, the filter matches with the public base URL. Services that do not match the filter will be discarded. If the regular expression cannot be compiled no services will be loaded.

Note: If a service does not match, but is included in the APICAST_SERVICES_LIST, service will not be discarded

Steps To Reproduce
  1. [step 1 (json configuration file, if applies)]
  2. [step 2 (curl commands to reproduce, if applies)]
  3. [step 3]
Current Result

Example:

Regexp Filter: http://.*.google.com Service 1: backend endpoint http://www.google.com Service 2: backend endpoint http://www.yahoo.com Service 3: backend endpoint http://mail.google.com Service 4: backend endpoint http://mail.yahoo.com

The services that will be configured in Apicast will be 1 and 3. Services 2 and 4 will be discarded.

Expected Result

In this case, public base URL is supposed to be a gateway URL, but example demonstrates a google URL. It is not clear if this means backend is filtered here or gateway
https://github.com/3scale/apicast/blob/master/doc/parameters.md#apicast_services_filter_by_url

@eloycoto
Copy link
Contributor

@raghubanda what do you want is to change the URL examples to something more API specific?

Regards.

@metaversed
Copy link
Author

@eloycoto basically, if it can be made clear that the purpose is to fetch the configuration of the services from the Admin Portal based on a specific public base URL i.e the gateway URL .
In this case google.com is more like a API backend rather than it being a gateway url instead

eloycoto added a commit to eloycoto/APIcast that referenced this issue Jun 18, 2019
This fixes 3scale#1069 issue where Backend API was set as google.com and
yahoo.com due to in markdown files the urls need to be real.

Encoded the urls as code, and create some user-friendly api backend.

Signed-off-by: Eloy Coto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants