Skip to content

Commit

Permalink
Openshift: remove dnsmasq
Browse files Browse the repository at this point in the history
DNSmasq process was not handled by Apicast at all, dnsmasq process can die and
will never be up, so dns queries will start to fail.

The reasons to have APICast were:

- Openshift cluster provided multiple DNS servers in the resolv.conf:
not anymore, currently is using a Kubernetes service with static IP, so
all connections goes to the same service.
- DNS service was block during pod updates, no longer a case, it's
working correctly, added more pods in to a service and do not have the
case.
- Cache was not used, no longer needed due to `resolver.search_dns` is
looking for the full query in the cache before make the dns request to
the server. [0]

Fix THREESCALE-1555

[0] https://github.com/3scale/APIcast/blob/41ad2c2a04054cd05991a65fc807a8105cdb2fd6/gateway/src/resty/resolver.lua#L282-L302

Signed-off-by: Eloy Coto <[email protected]>
  • Loading branch information
eloycoto committed Aug 6, 2019
1 parent 0a3038f commit 031999d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Added new parameters to logging policy to allow custom access log [PR #1081](https://github.com/3scale/APIcast/pull/1089) [THREESCALE-1234](https://issues.jboss.org/browse/THREESCALE-1234)[THREESCALE-2876](https://issues.jboss.org/browse/THREESCALE-2876)
- Added http_proxy policy to use an HTTP proxy in api_backed calls. [THREESCALE-2696](https://issues.jboss.org/browse/THREESCALE-2696) [PR #1080](https://github.com/3scale/APIcast/pull/1080)
- Option to load service configurations one by one lazily [PR #1099](https://github.com/3scale/APIcast/pull/1099)
- Remove dnsmasq process for APIcast [PR #1090](https://github.com/3scale/APIcast/pull/1090), [THREESCALE-1555](https://issues.jboss.org/browse/THREESCALE-1555)

## [3.6.0-rc1] - 2019-07-04

### Added

- Extended variables in Liquid template operations [PR #1081](https://github.com/3scale/APIcast/pull/1081)[THREESCALE-2927](https://issues.jboss.org/browse/THREESCALE-2927)


## [3.6.0-beta1] - 2019-06-18

### Added
Expand Down
8 changes: 0 additions & 8 deletions gateway/.s2i/bin/run
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,4 @@ else
apicast=apicast
fi

dnsmasq --listen-address=127.0.0.1 --port=5353 \
--all-servers --no-host --no-hosts \
--cache-size=1000 --no-negcache --domain-needed \
--server="${RESOLVER:-}" \
--log-facility=- ${DNSMASQ_OPTIONS:-} \

export RESOLVER=127.0.0.1:5353

exec "${apicast}" "$@"

0 comments on commit 031999d

Please sign in to comment.