Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flexible warn and skip #581

Merged
merged 3 commits into from
Apr 17, 2023
Merged

flexible warn and skip #581

merged 3 commits into from
Apr 17, 2023

Conversation

mganisin
Copy link
Collaborator

  • Flexible warn_and_skip
  • Use warn_and_skip for SSO
  • Use warn_and_skip for websocket tests

Marian Ganisin added 2 commits April 14, 2023 15:05
Flexible warn_and_skip
3053e60 
Introducing warn_and_skip that can change based on configuration.
warn_and_skip printed warning and skipped the test (with same message).
Rhis could lead to missed tests (e.g. prometheus in case of missing
prometheus configuration). Now behavior of warn_and_skip can be degined
for individual tests. Most importantly it can skip or fail, so no
overlook should be a risk anymore (in case of proper configuration).

Furthermore, this can be used the other way to skip more tests based on
preliminary conditions.
Use warn_and_skip for SSO
695be22
@mganisin mganisin requested review from pehala and jakurban April 14, 2023 15:10
pehala
pehala approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@pehala pehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, great job!

@mganisin mganisin merged commit fadfce3 into 3scale-qe:main Apr 17, 2023
@mganisin mganisin mentioned this pull request Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehala pehala pehala approved these changes

@dhlavac dhlavac dhlavac approved these changes

@jakurban jakurban Awaiting requested review from jakurban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mganisin @pehala @dhlavac