Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use labels to select workflow job notification channels #58

Conversation

smrz2001
Copy link
Collaborator

@smrz2001 smrz2001 commented Mar 5, 2024

This PR is the most surgical change to the CD manager to split notifications. I punted on making a more complicated, deeper change for now.

Labels will have to be passed through when creating workflow type jobs so I'm creating separate PRs for that.

@smrz2001 smrz2001 requested a review from 3benbox March 5, 2024 21:11
@smrz2001 smrz2001 self-assigned this Mar 5, 2024
Copy link

linear bot commented Mar 5, 2024

Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smrz2001 smrz2001 enabled auto-merge (squash) March 5, 2024 21:43
@smrz2001 smrz2001 disabled auto-merge March 5, 2024 21:43
@smrz2001 smrz2001 merged commit 1a5a822 into develop Mar 5, 2024
1 of 3 checks passed
@smrz2001 smrz2001 deleted the feature/ws1-1441-move-cd-notifications-to-new-discord-channels branch March 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants