Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit on completion #237

Merged
merged 2 commits into from
May 14, 2024
Merged

fix: exit on completion #237

merged 2 commits into from
May 14, 2024

Conversation

smrz2001
Copy link
Contributor

Needed with NodeJS v20.

@smrz2001 smrz2001 requested review from stbrody and 3benbox May 14, 2024 18:52
@smrz2001 smrz2001 merged commit ccc7fae into main May 14, 2024
1 check passed
@smrz2001 smrz2001 deleted the fix/ci branch May 14, 2024 18:52
stbrody
stbrody reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@stbrody stbrody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of weird that node 20 needs this? Anyway lgtm

@smrz2001
Copy link
Contributor Author

smrz2001 commented May 14, 2024 •
edited
Loading

kind of weird that node 20 needs this? Anyway lgtm

Yeah ☹️ Had to make the same change for the anchor workers. I'm sure there's a precise explanation but the fix seemed harmless, and was what the consensus was online.

It's likely because of a bug in our reporting code where we don't wait for an operation to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbrody stbrody stbrody left review comments

@3benbox 3benbox Awaiting requested review from 3benbox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smrz2001 @stbrody