feat: move out auth/provider to parent window provider #33

zachferland · 2020-05-14T02:17:05Z

TODO
~~[] some added logic with state moved here now so should now add tests for that~~
[] since full migration available, probably will add here as well and feature flag (mainly just auth and migration of all spaces, full migration will have more account management and linking not added now)
~~[] small changes to 3boxjs and idw will be pushed up~~
~~[] test with more providers (mostly the ui part, can overlay still right now, just need right zindex, later wont want to make that assumption) (maybe just add web3modal to 3boxjs example)~~

zachferland · 2020-05-25T14:22:32Z

Remaining:

bug when denying signature (errors not propagated correclty)
version iframe, since last release minimally deployed, can break with upgrade, but cant break existing deployments by upgrading the iframe here

zachferland · 2020-05-27T01:10:24Z

@oed unfortunately not ready to merge yet, found issue where getting "Could not append entry, key ..." on first space auth, but not on following auth, didnt see earlier, appears to be regression, but didnt find which change yet, ran out to time to fix today, will continue in morning

oed

Looks good. Do you think it makes sense to get CAIP-10 in now, or wait until full migration. We also have upcoming work to support CAIP-10 in blockchain-utils next sprint.

oed · 2020-05-29T08:23:49Z

.circleci/config.yml

+          # filters:
+          #   branches:
+          #     only: develop


Should these be commented out?

for now, just wanted branches deployed to dev

oed · 2020-05-29T08:31:37Z

iframe/index.js

-window.getProvider = (address) => {
-  return store.get(`provider_${address}`)
-}
+const mobileRegex = /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i


I assume you tested this on your BlackBerry 😝

yup and my windows phone :) this is left over from before, reminded me, will probs switch this to a lib to handle

oed · 2020-05-29T08:35:30Z

package.json

+    "3id-blockchain-utils": "github:ceramicnetwork/js-3id-blockchain-utils#feat/ethereum-auth-function",
    "@babel/runtime": "^7.1.2",
-    "@portis/web3": "^2.0.0-beta.54",
-    "@walletconnect/web3-provider": "^1.0.0-beta.47",
-    "authereum": "0.0.4-beta.129",
-    "fortmatic": "^2.0.5",
-    "identity-wallet": "^1.2.0",
+    "identity-wallet": "github:3box/identity-wallet-js#feat/3id-connect-v2",


These should be merged/released before this is merged?

oed · 2020-05-29T08:38:22Z

src/authProvider/abstractAuthProvider.js

+    * @param     {String}    accountId          Id of account used with provider, most often hex address
+    * @return    {String}                       A 32-64 bytes hex string
+  */
+  async authenticate(message, accountId) {


This should be a CAIP-10 accountId right?

See here for an example: https://github.com/ceramicnetwork/js-ceramic/blob/develop/packages/account-template/src/accountLinks.ts#L23-L26

yeah thats the plan after 👍 wont matter here after, just getting passed through, but will in other places

oed · 2020-05-29T08:39:13Z

src/authProvider/abstractAuthProvider.js

+    * @param     {String}    accountId     Id of account used with provider, most often hex address
+    * @return                              Returns on success
+  */
+  async createLink(did, accountId) {


CAIP-10 here as well?

oed · 2020-05-29T08:43:31Z

src/threeIdConnect.js

@@ -1,13 +1,18 @@
 import ThreeIdProviderProxy from './threeIdProviderProxy.js'
 import { expose } from 'postmsg-rpc'
+import EthereumAuthProvider from './authProvider/ethereumAuthProvider.js'
+import { fakeIpfs } from 'identity-wallet/lib/utils'


Looks like fakeIpfs isn't used.

yup recently, gonna remove

oed · 2020-05-29T08:50:35Z

src/threeIdConnectService.js

-    }
-    return this._threeId
+  _write3idState(state, address) {
+    store.set(serializedKey(address), state)


We should probably use CAIP-10 accountId here as well.

oed · 2020-05-29T08:56:46Z

src/threeIdConnect.js

+  async migration(spaces, address) {
+    const threeId = await this._getThreeId(address)
+    await threeId.authenticate(spaces)
+    return threeId.serializeState()
+  }


So the reason we are using the ThreeId class here is because we need the logic that uses the Keyring class thats in 3box-js. If I understand this correctly than the keyring code should no longer be needed in 3box-js right?

Actually I think we don't even need the keyring class anymore. The main thing we need is openSpaceConsent and openBoxConsent. Am I missing something here?
If not this should be in scope for the full migration.

the keyring and really a lot of the 3id class currently in 3boxjs wont be needed anymore, and yup plan is to refactor in the future

there is a bit more logic (simple though, like serializing, creating all keyrings for spaces, etc), and its nice to reuse to code (including current keyring) that has been working for a while, but yeah could be pulled out as migration module or something as part of refactor

zachferland · 2020-05-29T13:23:25Z

Some more context, this assume eth providers still, but yeah shortly will generalize to any (some parts here), but will add docs on adding support (similar to before) but now in this repo, will add provider detection so should be able to detect providers and map to provided implementation (will be able to pass any supported provider without any extra work in 3boxjs), CAIP-10 account ids instead of addresses

feat: move out auth/provider to parent window provider

f7e6ece

zachferland force-pushed the feat/external-provider branch from 586b29b to f7e6ece Compare May 15, 2020 18:42

oed assigned zachferland May 19, 2020

zachferland added 2 commits May 19, 2020 14:01

feat: change to small corner/bottom consent modal

910d1c4

feat: design

b874f15

zachferland force-pushed the feat/external-provider branch 6 times, most recently from 3908b4d to 2114ee0 Compare May 21, 2020 00:09

feat: mobile fix, transitions

03d1169

zachferland force-pushed the feat/external-provider branch from 2114ee0 to 03d1169 Compare May 21, 2020 14:04

zachferland added 2 commits May 22, 2020 09:43

fix: browser css, clear render, css names, etc

0f0a0a0

feat: 3box branding, button states

12d9e9d

zachferland force-pushed the feat/external-provider branch from ddf2048 to 12d9e9d Compare May 22, 2020 19:40

feat: simplfied error handling

6cb9064

zachferland force-pushed the feat/external-provider branch from fb41d37 to 6cb9064 Compare May 25, 2020 16:15

zachferland added 2 commits May 26, 2020 18:07

ref: auth message, design

5b87684

feat: catch 404, remove circ dep

5341310

zachferland requested a review from oed May 28, 2020 17:42

fix: 3id/ipfs conflicts with 3id-connect fix

a7a1d24

zachferland force-pushed the feat/external-provider branch from 3513499 to a7a1d24 Compare May 28, 2020 18:08

oed reviewed May 29, 2020

View reviewed changes

oed approved these changes May 29, 2020

View reviewed changes

zachferland force-pushed the feat/external-provider branch from a995efb to 9515c12 Compare May 29, 2020 19:59

feat: iframe versoning

a74b528

zachferland force-pushed the feat/external-provider branch from 9515c12 to a74b528 Compare May 30, 2020 17:36

zachferland merged commit b0184e5 into develop May 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move out auth/provider to parent window provider #33

feat: move out auth/provider to parent window provider #33

zachferland commented May 14, 2020 •

edited

Loading

zachferland commented May 25, 2020

zachferland commented May 27, 2020

oed left a comment

oed May 29, 2020

zachferland May 29, 2020

oed May 29, 2020

zachferland May 29, 2020

oed May 29, 2020

zachferland May 29, 2020

oed May 29, 2020

oed May 29, 2020

zachferland May 29, 2020

oed May 29, 2020

oed May 29, 2020

zachferland May 29, 2020

oed May 29, 2020

oed May 29, 2020

zachferland May 29, 2020

zachferland commented May 29, 2020

feat: move out auth/provider to parent window provider #33

feat: move out auth/provider to parent window provider #33

Conversation

zachferland commented May 14, 2020 • edited Loading

zachferland commented May 25, 2020

zachferland commented May 27, 2020

oed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zachferland commented May 29, 2020

zachferland commented May 14, 2020 •

edited

Loading