Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

Feat/idw iframe #14

Merged
merged 19 commits into from
Apr 14, 2020
Merged

Feat/idw iframe #14

merged 19 commits into from
Apr 14, 2020

Conversation

zachferland
Copy link
Contributor

@zachferland zachferland commented Apr 9, 2020

tie up links to dependent releases (circle ci will publish again then)
src/ will likely be npm package - could eventually separate the actual iframe implementation entirely
will likely change some file names to mirror name change
enable specific branch flows ci config

There is final design elements kenzo/sena will coordinate on.

@zachferland zachferland requested a review from oed April 9, 2020 13:36
Copy link
Member

@oed oed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really clean!
Main question is around if we need to pull out the threeId module from 3box-js?

src/threeIdConnect.js Show resolved Hide resolved
src/threeIdConnectService.js Outdated Show resolved Hide resolved
src/threeIdConnectService.js Outdated Show resolved Hide resolved
* @return {String} response message string
*/
async providerRelay(message) {
const domain = new Url(document.referrer).hostname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@zachferland zachferland force-pushed the feat/idw-iframe branch 4 times, most recently from 533bdf6 to 84c4516 Compare April 14, 2020 01:25
@zachferland
Copy link
Contributor Author

May need to pull out threeId module from 3box-js, but if so, will be in another pr

@zachferland zachferland merged commit 84fb121 into develop Apr 14, 2020
zachferland added a commit that referenced this pull request Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants