This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really clean!
Main question is around if we need to pull out the threeId module from 3box-js?
* @return {String} response message string | ||
*/ | ||
async providerRelay(message) { | ||
const domain = new Url(document.referrer).hostname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
zachferland
force-pushed
the
feat/idw-iframe
branch
from
April 13, 2020 16:56
4769583
to
49a9a0f
Compare
zachferland
force-pushed
the
feat/idw-iframe
branch
from
April 13, 2020 17:53
49a9a0f
to
fd0de4d
Compare
zachferland
force-pushed
the
feat/idw-iframe
branch
4 times, most recently
from
April 14, 2020 01:25
533bdf6
to
84c4516
Compare
zachferland
force-pushed
the
feat/idw-iframe
branch
from
April 14, 2020 01:40
84c4516
to
20bc6f9
Compare
May need to pull out threeId module from 3box-js, but if so, will be in another pr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tie up links to dependent releases (circle ci will publish again then)
src/ will likely be npm package - could eventually separate the actual iframe implementation entirely
will likely change some file names to mirror name changeenable specific branch flows ci config
There is final design elements kenzo/sena will coordinate on.