This repository has been archived by the owner on Aug 9, 2021. It is now read-only.
build: package bundler hint to excluded node modules #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #132 +/- ##
========================================
Coverage 84.61% 84.61%
========================================
Files 6 6
Lines 377 377
Branches 51 51
========================================
Hits 319 319
Misses 50 50
Partials 8 8Continue to review full report at Codecov.
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLHttpRequest already does this, and it should be a sufficient hint for any bundler to not include the node modules, but it is not working for a number of people. This makes it more explicit, by specifying the same in our own package.