Skip to content

None map type & OSM performance improvements #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2024
Merged

None map type & OSM performance improvements #904

merged 4 commits into from
Oct 29, 2024

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Oct 29, 2024

and new feature -- none!

to test:

  • use the new osm3d option, see if buildings look ok for a new location (optional draw call testing [1] but it's tedious and I already did it)
  • test new "none" map type -- can switch to / from without problem? does the map attribution disappear for none? can you save and reload and then change to another map type and the location is still retained?

[1] Optional testing draw call improvement on buildings:

Previous (before this PR):

  • on a scene with location set and osm3d map type
  • run on console: AFRAME.scenes[0].setAttribute('stats','')
  • hide the geospatial > osm 2d tiles layer (also hide other street layers that might interfere with this test)
  • zoom out to see all buildings and notice that the draw calls increases as you zoom out and see all buildings, then zoom in and observe draw call decreasing

After:

  • draw call should not increase / decrease when zooming in and out and looking at osm buildings (also hide other street layers that might interfere with this test)

kfarr added 4 commits October 28, 2024 21:01
- fix drawcall issue
- use parent entity, fix select issue
- remove extra console logs
now that perf is ok
@kfarr kfarr requested a review from rahulkgupta October 29, 2024 05:28
@kfarr kfarr merged commit f39826c into main Oct 29, 2024
1 check passed
@kfarr kfarr deleted the osm-perf-update branch October 29, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant