-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up code in AddLayerPanel component and drag and drop #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent, use useMemo to compute selectedCards
… on non segment to match the created entity
vincentfretin
force-pushed
the
add-panel
branch
from
August 8, 2024 13:18
7209bc6
to
3865d6c
Compare
…and current camera position
…ty and not from a child
vincentfretin
changed the title
Clean up code in AddLayerPanel component
Clean up code in AddLayerPanel component and drag and drop
Aug 8, 2024
@kfarr Drag an drop implemented, creating the element in 3dstreet-container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly code cleanup and creating pure functions (not using variables from outside the function) to better understand this code.
I fixed some issues and implemented drag and drop.
This closes #576