Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select entity on raycaster click if we used one of the controls take 2 #710

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

vincentfretin
Copy link
Collaborator

Better fix for #645, revert #709
With further testing while backporting it to aframe-inspector, I still reproduced the issue sometimes when just waiting long enough after moving the mouse and release the mouse button. Actually the fix is simpler, I just used the exact condition as the three.js editor, just compare if mouse distance is zero to do the select entity, that's it.
aframevr/aframe-inspector#734

@vincentfretin vincentfretin self-assigned this Jul 16, 2024
@kfarr kfarr merged commit 3f19531 into main Jul 16, 2024
1 check passed
@kfarr kfarr deleted the better-select-entity-on-drag-fix branch July 16, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants