Streetplan support #503
Merged
Streetplan support #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add streetplan utils
add variantString to all types and subtypes add tagToVariantString JSON mapping option support fix generating VariantString from keys ad basic materials mapping
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
add description add more variants support fix some existing variants support
|
Added Setback segment support in last commits. |
use this url to test: http://localhost:7001/streetplan.html#https://api.allorigins.win/raw?url=https://upd.streetplan.net/streets-3d-data/79303
- remove streetmix-loader dependency since streetplan-loader may be used instead - add a bit more to our hacky matching string of streetplan to reduce unintended collisions, such as a streetmix street title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first version is currently working with the test response from Streetplan: exampleJOSN.json. Buildings are not yet supported. The remaining segments mostly now work with default options.
What's next:
Also I'll make suggestions for Streetplan developer for JSON structure. For example it will be good to save units in JSON - feet/meters