Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

striping, rail, ped sidepanels + add/remove generated components #1052

Merged
merged 15 commits into from
Feb 4, 2025

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Feb 2, 2025

this brings back the ability to delete a component

it also re-adds the ability to add a component, but only for street-segment entities in a managed street

things that might be good to fix:

  • styling for "add component" in street segment sidepanel
  • the right-panel drop down menu still isn't visible below panel (this affects other panels too, not unique to this)

@kfarr kfarr changed the title barely working delete component striping, rail, ped sidepanels + add/remove generated components Feb 4, 2025
@kfarr kfarr requested a review from vincentfretin February 4, 2025 07:57
@kfarr kfarr marked this pull request as ready for review February 4, 2025 07:57
Copy link
Collaborator

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. There are indeed some styling issues to fix on the add component select. I ended up fixing the original aframe inspector code ahah.

@kfarr kfarr merged commit 7257c4b into main Feb 4, 2025
1 check passed
@kfarr kfarr deleted the delete-component branch February 4, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants