Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6296 - basic_test.py::test_conn_limits fails in main branch #6300

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jchapma
Copy link
Contributor

@jchapma jchapma commented Aug 15, 2024

Description:
A CI test to validate connection management functionality by configuring an instance with a very small connection table fails, with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table code has been updated to expand the connection table size to include a head for each list. This expanded size needs to be accounted for when we determine if we can accept new connections and on final check at server starup time.

Relates: #6296

Reviewed by:

Description:
A CI test to validate connection management functionality by
configuring an instance with a very small connection table fails,
with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table
code has been updated to expand the connection table size to include
a head for each list. This expanded size needs to be accounted for
when we determine if we can accept new connections and on final check
at server starup time.

Relates: 389ds#6296

Reviewed by:
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchapma jchapma merged commit e70c22f into 389ds:main Aug 21, 2024
195 checks passed
@tbordaz
Copy link
Contributor

tbordaz commented Aug 28, 2024

Hi @jchapma , does it apply to others branches than main ? I am see similar errors in 2.5 branch

@jchapma
Copy link
Contributor Author

jchapma commented Aug 28, 2024

Hi @jchapma , does it apply to others branches than main ? I am see similar errors in 2.5 branch

Hi @tbordaz , It does, let me cherry it back to relevant branches

jchapma added a commit that referenced this pull request Aug 29, 2024
)

Description:
A CI test to validate connection management functionality by
configuring an instance with a very small connection table fails,
with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table
code has been updated to expand the connection table size to include
a head for each list. This expanded size needs to be accounted for
when we determine if we can accept new connections and on final check
at server starup time.

Relates: #6296

Reviewed by: @droideck  (Thank you)
jchapma added a commit that referenced this pull request Aug 29, 2024
)

Description:
A CI test to validate connection management functionality by
configuring an instance with a very small connection table fails,
with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table
code has been updated to expand the connection table size to include
a head for each list. This expanded size needs to be accounted for
when we determine if we can accept new connections and on final check
at server starup time.

Relates: #6296

Reviewed by: @droideck  (Thank you)
jchapma added a commit that referenced this pull request Aug 29, 2024
)

Description:
A CI test to validate connection management functionality by
configuring an instance with a very small connection table fails,
with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table
code has been updated to expand the connection table size to include
a head for each list. This expanded size needs to be accounted for
when we determine if we can accept new connections and on final check
at server starup time.

Relates: #6296

Reviewed by: @droideck  (Thank you)
jchapma added a commit that referenced this pull request Aug 29, 2024
)

Description:
A CI test to validate connection management functionality by
configuring an instance with a very small connection table fails,
with the instance failing to start.

Fix description:
In a multi list connection table configuration, the connection table
code has been updated to expand the connection table size to include
a head for each list. This expanded size needs to be accounted for
when we determine if we can accept new connections and on final check
at server starup time.

Relates: #6296

Reviewed by: @droideck  (Thank you)
@jchapma
Copy link
Contributor Author

jchapma commented Aug 29, 2024

812d058..bcc61cd 389-ds-base-3.0 -> 389-ds-base-3.0
4de8658..8f9268e 389-ds-base-2.5 -> 389-ds-base-2.5
593faba..07686ab 389-ds-base-2.4 -> 389-ds-base-2.4
2b06fd2..e322605 389-ds-base-2.3 -> 389-ds-base-2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants