Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New validation on entry works a little to good #3525

Closed
trouble2 opened this issue Dec 9, 2024 · 2 comments
Closed

New validation on entry works a little to good #3525

trouble2 opened this issue Dec 9, 2024 · 2 comments
Assignees

Comments

@trouble2
Copy link

trouble2 commented Dec 9, 2024

I'm submitting a

[x] bug report

...about

[x] edit experience / UI

Current Behavior / Expected Behavior

You kind-of solved an issue in the previous release saying:
Show better indication when item in Entity-Picker doesn't exist #3504
So that was really nice :-), only the validation can get stuck.
I'll try to explain.

Instructions to Reproduce the Problem

Right now, when I add a new item in the blog module, the 'Add' button is greyed out because there are some required fields I have to fill. Like:

  • title
  • content
  • category
  • author

When I fill these, the 'Add' button turns blue/active, so I can save my new blogpost.
So far everything works perfect.

However, when I click on the plus button to add a new entry, and then click on the greyed out 'Add' button.
It first shows a toast/popup message saying which fields are required.
Then, when I fill these field (I made sure I really, really filled the required fields, trust me)
The button still stays greyed out/disabled.

So I think there is something not totally correct yet in the validation:
image

Maybe it has something to do with the fact you first have to enter a title before you can enter other fields in the blog app, but I'm not sure about that...

Your environment

  • 2sxc version(s): 18.6.1
  • Browser: all
  • DNN: 9.13.04
  • Hosting platform: azure
  • Language: Dutch
@iJungleboy
Copy link
Contributor

@trouble2 I have a feeling this is a UX problem, not a data problem. still needs fixing, but I need to be sure.

Did you just type the word - or type the word and select something?

image

...because if you type the word and leave the field, it doesn't select anything, just shows you the search-text you had been typing before.

I would still need to fix it, but I must be sure I'm fixing the right problem - and at least my tests worked IF I selected the item.

@iJungleboy iJungleboy self-assigned this Dec 9, 2024
@iJungleboy
Copy link
Contributor

added fix so UI is cleared if the user didn't actually select anything.

to be released in 1-2 days.

@github-project-automation github-project-automation bot moved this to Done in 2sxc 18 Dec 9, 2024
@iJungleboy iJungleboy moved this to Done in 2sxc 19 Dec 12, 2024
@iJungleboy iJungleboy moved this from Done to v19.00.00 in 2sxc 19 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: v19.00.00
Development

No branches or pull requests

2 participants