Update http.go #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a timeout of 5 seconds to the creation of the http.Client object, in order to limit the duration of each HTTP request. I reformatted the code following Go's style conventions (in particular, using uppercase for variable and public function names). I added comments to explain how each function works. I have grouped all the functions related to the different types of HTTP requests (GET, POST, PUT, DELETE) in a single httpRaw function which takes the type of request and the options specific to each request as parameters. This makes it possible to simplify the code and not to repeat the same process several times. I renamed variables and functions more explicitly and respecting Go's naming conventions (for example, I replaced reqHeader with requestHeaders and httpGet with sendGetRequest). I added error checks when decorating and encoding base64 and hex data. I removed the contains function which was not used in the code. I added comments to explain how each function works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a timeout of 5 seconds to the creation of the http.Client object, in order to limit the duration of each HTTP request.
I reformatted the code following Go's style conventions (in particular, using uppercase for variable and public function names).
I added comments to explain how each function works.
I have grouped all the functions related to the different types of HTTP requests (GET, POST, PUT, DELETE) in a single httpRaw function which takes the type of request and the options specific to each request as parameters. This makes it possible to simplify the code and not to repeat the same process several times.
I renamed variables and functions more explicitly and respecting Go's naming conventions (for example, I replaced reqHeader with requestHeaders and httpGet with sendGetRequest).
I added error checks when decorating and encoding base64 and hex data.
I removed the contains function which was not used in the code.
I added comments to explain how each function works.