Mark unsupported insecure profiles as deprecated - #6057
Closed
eliotcougar wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@2dust, feel free to reject it. It is a temporary measure kind of feature until people migrate to more secure service providers. |
eliotcougar
marked this pull request as ready for review
August 10, 2026 14:18
Owner
|
感谢 PR |
Contributor
Author
I agree. However, I still think that deprecation of the insecure configurations by xray-core is not communicated well. The error message given by the app is not specific enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent Xray-core changes reject several insecure outbound configurations instead of attempting to connect them. v2rayNG currently leaves those profiles looking usable on the main screen, so users often discover the incompatibility only after connection or real-delay tests fail.
This PR identifies profiles rejected by the Xray-core revision pinned by AndroidLibXrayLite, gives them a light-red background, and replaces their protocol label with
DEPRECATED. It does not disable editing, sharing, or removal, and it does not change connection behavior.Related to #6046.
Compatibility rules
The detector mirrors the insecure-outbound checks from pinned Xray-core commit
5ca6f4b7d4dc:noneor empty) to public endpoints;allowInsecurebehavior for VMess, VLESS, Shadowsocks, Trojan, or Hysteria2, unless apinnedCA256certificate fingerprint prevents that setting from being emitted.Xray's private-endpoint exceptions are mirrored as well. Private and reserved IP ranges, dotless hostnames, and Xray's recognized local/private domain suffixes are not marked merely for lacking transport security.
Cache and refresh behavior
Compatibility is evaluated once when a profile snapshot is decoded into
ServersCache; Compose list recompositions reuse the cached Boolean rather than re-parsing addresses and CIDR ranges.The cache is naturally rebuilt after foreground imports, edits, and list reloads. For scheduled subscription updates,
SubscriptionUpdateServicenow emits a targeted data-change event only after a successful profile replacement or a non-empty test run. The main view invalidates the changed subscription and the aggregate All cache, immediately rebuilds only the affected group currently on screen, and leaves other large groups to reload lazily when selected. Cache invalidation is synchronized with background preloading so an in-flight preload cannot restore a stale snapshot.Validation
allowInsecure, and unrelated protocols.:app:testPlaystoreDebugUnitTest --tests com.v2ray.ang.core.XrayOutboundCompatibilityTest:app:assemblePlaystoreDebug -PABI_FILTERS=x86_64