Skip to content

Add subscription network type filtering - #6056

Closed
eliotcougar wants to merge 1 commit into
2dust:masterfrom
eliotcougar:codex/issue-6040-network-type-filter
Closed

Add subscription network type filtering#6056
eliotcougar wants to merge 1 commit into
2dust:masterfrom
eliotcougar:codex/issue-6040-network-type-filter

Conversation

@eliotcougar

Copy link
Copy Markdown
Contributor

Summary

  • add an optional network type filter directly after the subscription remarks filter
  • accept case-insensitive, comma-separated transport values such as ws, grpc, and xhttp
  • persist the filter with the subscription and apply it while parsing imported profiles
  • localize the field label and placeholder across all nine maintained catalogs

Why

Subscription groups can currently filter imported profiles by remarks, but not by transport type. Users therefore cannot retain only profiles using selected transports without encoding that information into profile remarks.

Closes #6040.

User impact

Leaving the new field blank preserves the existing import behavior. When values are supplied, only profiles whose network type matches one of the comma-separated entries are imported. Matching ignores case and surrounding whitespace.

Validation

  • :app:compilePlaystoreDebugKotlin
  • XML structural audit: all nine catalogs contain 452 ordered resource identifiers with no duplicates
  • git diff --check

No test source files are included in this PR.

@eliotcougar
eliotcougar marked this pull request as ready for review August 10, 2026 10:59
@2dust 2dust closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network type filtering

2 participants