Makes the camera function optional #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its better to have nothing there. So there comes the message "No display configuration matched. Exiting..." after first call of app.py. Its better then to have a fault message like "OSError: [Errno 121] Remote I/O error"
AxelHamburch
commented
Mar 30, 2022
lightisfaster
approved these changes
Mar 30, 2022
app.py
Outdated
| # 2. Offer to cancel and switch to normal scan | ||
| # 3. Process payment | ||
| if activewallet == "lntxbot": | ||
| if activewallet == "lntxbot" and camera == "yes": |
There was a problem hiding this comment.
boolean true or false is more common
|
I've just made a small change for the boolean flag camera. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the config.ini by asking whether a camera is available and by asking which language you want to use. Only the part with the camera is active here. The language part follows in a subsequent PR.
The function is that you can specify whether a camera is available or not. It is disabled by default as most will have the pocket version. Now that we know that there is no camera, we can also skip or disable functions that only make sense when the camera is active. For example, the page with the query whether LNURL is possible. If not, then the camera has been activated. This site is useless for people without a camera and without a button. So we can skip the function right now and people don't have to laboriously edit this page call in the app.py code anymore.
The next point is the function that is called when the button is pressed 5 times. All wallet data is currently being deleted and there is the option of rescanning the data. But if I don't have a camera, only my data is erased and I have to laboriously re-enter it by hand. That's why we can block this function in the future if you don't have a camera.