fix: Parser does not swallow property values #578
Conversation
| @@ -102,7 +105,7 @@ qui dolorem eum fugiat quo voluptas nulla pariatur?" | |||
| CLOCK: [2019-11-11 Mon 13:12]--[2019-11-12 Tue 13:12] => 24:00 | |||
| CLOCK: [2019-10-13 Sun 12:15]--[2019-10-13 Sun 14:12] => 1:57 | |||
| :END: | |||
| ** A messy headline with trailing whitespace | |||
| ** A messy headline with trailing whitespace | |||
There was a problem hiding this comment.
Ups, did you remove the trailing whitespace here?
There was a problem hiding this comment.
Nope, Emacs did(;
Thanks for the quick review. I'll revert this of course.
Haven't read through the diff, yet. Only fixed the issue at hand. I would have hoped to also catch it, but you were blazingly fast. Thanks a bunch 🙏
There was a problem hiding this comment.
Haha, I'm faster than all tests :D
There was a problem hiding this comment.
Really impressive! 🚀 
|
Btw, to all the readers: Sorry I'm doing this PR before reviewing/commenting on others. I'm still working like mad on our new product, which is live now, but the customer has daily new change requests that need to be deployed asap^^ And this bug actually tripped me up in our companies project management Org file, so I needed to fix it quickly. |
organice understands
:PROPERTIES:drawers and smartly parses the values in case one of the values is a timestamp. However, parsing all the values and saving the parsed result in any case will lead to wrong results. Most values of properties are just plain text and non-interactive things in Org mode.Hence, before this fix, we'd have problems like:
Because organice believed this to be text with
_which yields underlined text.