Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place cursor after the TODO keyword when creating a new header #193

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

schoettl
Copy link
Collaborator

@schoettl schoettl commented Jan 1, 2020

This PR supersedes #168. As discussed there and in the linked comment, placing the cursor at the end of the input is problematic. But not for newly added headers, that only contain the TODO keyword.

PR #168 can be closed without merge.

Copy link
Collaborator Author

@schoettl schoettl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@munen
Copy link
Collaborator

munen commented Jan 2, 2020

Lgtm, too^^

@munen munen merged commit 1dca6ba into 200ok-ch:master Jan 2, 2020
@munen
Copy link
Collaborator

munen commented Jan 2, 2020

Updated the changelog with the attribution: d1e09ee

Thank you for adding the feature. It's a very nice UX improvement 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants