Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim headline title at both sides before saving #177

Merged
merged 2 commits into from
Jan 1, 2020

Conversation

schoettl
Copy link
Collaborator

... when capturing via template and when adding/editing a headline.

Makes sense?

I think it does not make sense to have trailing whitespace in any source code. OK, markdown uses trailing whitespace to declare a <br> but a headline in emacs does not need trailing space, right?

When capturing via template and when adding/editing a headline.
@munen
Copy link
Collaborator

munen commented Jan 1, 2020

Good thinking!

I completely agree that trimming whitespace for a newly created headline is a good idea and that we should do it. There's no semantics to trailing whitespace and having it is likely an input error.

I have added some documentation on where we do trim and where we don't trim trailing whitespace.

Nice addition, thank you @schoettl 🙏

@munen munen merged commit e5b5763 into 200ok-ch:master Jan 1, 2020
@munen
Copy link
Collaborator

munen commented Jan 1, 2020

I have updated the changelog with the attribution: b7f7a00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants