-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Google Analytics? #41
Comments
Hi @alphapapa Happy to hear that you like the general direction of the project! Regarding GA, I didn't know that it was integrated until a few days ago myself. I do understand that you don't like the integration at all. Personally, I'm no friend of Google (and similar companies) as well! Also, it would be blocked from any of my browsers^^ Which doesn't make the usage of GA itself a proper choice! Having said that, the first most important thing to mention is that no content is tracked (which otherwise would have been a huuge issue on org-web. The relevant code is here: https://github.com/200ok-ch/organice/blob/master/src/middleware/google_analytics_logging.js#L6 After I saw a couple of days ago that GA is integrated, I did change it to a new key, so that I can actually see the traffic. I did so, because organice still has lots of bugs (with some crashing the app) and in theory it would be nice to see/track those in some form somewhere. However, a proprietary solution like GA is certainly not the best place for that, so let me propose the following: I'll happily accept PRs with any of these features:
Would you be interested in doing one or the other? |
Let me rephrase the second option: I'm not actually interested in tracking people using organice, whatsoever! Therefore the second option doesn't even have to be product close to GA in functionality. However, I'm interested in getting automated crash-reports to learn about all the things going wrong for the community so that we can start to get organice into a stable and productive state. Even sending the crash-reports should be an opt-in feature, imo. Personally, I would have never integrated GA for organice. Like I said, I only found out about its integration very recently. |
Hi Alain, (I feel like I know you a little bit from watching that video presentation you put on YouTube where you demonstrated many things about Emacs.) I appreciate your thorough response. I'm not in a position to contribute to this project now, as I haven't actually used it yet, and I'm not familiar with the JavaScript frameworks and such that it uses. And I'm busy with several Org-related projects of my own. :) I do look forward to watching your progress and trying it in the future. For myself, having the analytics removed by default would probably be a prerequisite (I don't mean that as a demand, just my two cents). Thanks. |
Dear @alphapapa First, let me say thank you for watching the presentation! I entered that talk, as well as an intro to organice, into the call for proposals for EmacsConf 2019. Today, my business partner (@branch14)
I do appreciate your clear words on this topic. I must have not been very awake when I saw that GA is integrated. As much as I usually ramble about Google, I really had a lapse of consciousness here.
You did. Big time - you woke me up, thank you! 🙏 I'm happy to announce that as of now, organice is free of Google Analytics: 2e7b31c
Please continue filing issues for whatever seems off or needs improving. Your time and effort is greatly appreciated!
I did look into them and am happily impressed. Lots of elisp goodness to integrate into my Emacs configuration(; There's loads that looks amazing - I'll probably start with integrating org-super-agenda. Seeing that you're heavily invested in writing good tooling on top of Org, maybe you're interested in one of the side-projects we just started. We're writing a proper BNF based parser for Org. Our initial use-case is to integrate it into organice, but the parser can be integrated into any JavaScript or Java codebase, later. If you're interested, please find the repository here: https://gitlab.200ok.ch/200ok/org-parser Again, thank you very much for the issue and your other open source contributions! (^_^)/ If you're satisfied with my fix, please feel free to close the issue. PS: Some screenshots showing the current state: (The mentioned "google" API here is required for Google Drive synchronization) |
Dear @alphapapa I'm assuming you missed the notification (or didn't have the time) 9 days ago. I'm closing this issue in the good hopes that it has been resolved to your liking. If I'm mistaken, let's re-open and have a discussion^^ Thank you very much for your contribution to organice! Best regards |
Hi,
Thanks for starting this project to make
org-web
more widely useful, and for putting your resources behind it.Looking briefly at the code, the first thing I noticed was this:
organice/src/store.js
Line 3 in 47f562e
As an Emacs/Org user, that's quite off-putting. Were I to use and trust a project like this on my Org files, I'd want Google Analytics to be nowhere near any part of it.
Would you consider removing that from the code?
The text was updated successfully, but these errors were encountered: