Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dueling NPE #650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed dueling NPE #650

wants to merge 2 commits into from

Commits on Dec 31, 2023

  1. Fixed dueling NPE 

    Why was this null? Right clicking player and sending duel request via "Challenge" option produces an NPE, because packet is null, but ChallengePlayer checks packet.getOpcode without checking if packet is not null
    @ipkpjersi
    ipkpjersi committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    295af8f View commit details
    Browse the repository at this point in the history

  2. Added bounds check 

    We don't know if we will receive good data so might as well check it.
    @ipkpjersi
    ipkpjersi committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    4548d5a View commit details
    Browse the repository at this point in the history