Linter #63
Merged
Linter #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E722 Do not use bare `except` https://requests.readthedocs.io/en/latest/_modules/requests/exceptions/
F841 Local variable `count_findings_summary` is assigned to but never used
F821 Undefined name `Http404`
F821 Undefined name `LazyEncoder`
F841 Local variable `template_findings_summary` is assigned to but never used
E402 Module level import not at top of file
|
Thanks! let me take a look into ruff and these changes and I will commit if works |
1modm
approved these changes
Jan 18, 2023
1modm
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to lint the code and fix some code using ruff linter.
I put 1 change per commit so I would be easier for you if you want to revert one.
If everything is ok you can suash the PR.
Two rules remains that I wasn't able to handle: