Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Complier for macOS 12.3+ #598

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

WrathofthePast
Copy link
Collaborator

Explanation:

  • The mergeASARs API was introduced in electron-universal v1.2.0 and electron-builder implemented it in v23.0.0 along with the fix for the removal of Python 2.7. This feature caused compiling to fail with Can't reconcile two non-macho files.
  • After speaking to the creator of the mergeASARs API and reviewing various documentations, I discovered that build in "files": ... overrode the default ignores for any files within it. Those files are unmergable.
  • According to the electron-builder documentation:

Default pattern **/* is not added to your custom if some of your patterns is not ignore (i.e. not starts with !). package.json and **/node_modules/**/* (only production dependencies will be copied) is added to your custom in any case. All default ignores are added in any case — you don’t need to repeat it if you configure own patterns.

  • Since the default includes all needed files, simply removing "files": ... fixes the error and prevents future ones.

@WrathofthePast WrathofthePast requested a review from 1kc March 21, 2022 17:50
Copy link
Collaborator

@dhobi dhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

electron-builder:
- Updated to the latest release
- No longer a pre-release
- Now uses the same electron universal version as this PR (v1.2.1)

source-map-support
- Updated to dedupe
@1kc 1kc merged commit e6a9909 into 1kc:master Sep 21, 2022
JCKodel pushed a commit to JCKodel/razer-macos that referenced this pull request Dec 7, 2022
@king2302
Copy link

king2302 commented Oct 1, 2023

need fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 2.7 is removed from macOS in version 12.3+; Causes compiling to Fail
4 participants