Skip to content

v6.7 Tranche 1: kanban_complete verification gates (#28, #62, #64) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarvis-stark-ops merged 3 commits into from
Jun 10, 2026
Merged

v6.7 Tranche 1: kanban_complete verification gates (#28, #62, #64) #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
307e567
feat(kanban): v6.7 Tranche 1 — kanban_complete verification gates
Jun 9, 2026
aa127bd
fix(kanban): v6.7 Part 1 self-review — opt-out audit, hygiene scoping…
Jun 9, 2026
6b1bcd1
fix(kanban): N1 self-review — empty summary no longer crashes workspa…
Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions hermes_cli/kanban.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,13 +1894,19 @@ def _cmd_complete(args: argparse.Namespace) -> int:
failed: list[str] = []
with kb.connect_closing() as conn:
for tid in ids:
if not kb.complete_task(
conn, tid,
result=args.result,
summary=summary,
metadata=metadata,
expected_run_id=_worker_run_id_for(tid),
):
try:
ok = kb.complete_task(
conn, tid,
result=args.result,
summary=summary,
metadata=metadata,
expected_run_id=_worker_run_id_for(tid),
)
except (kb.CompletionGateError, kb.InvalidOptOutError) as gate_err:
failed.append(tid)
print(f"{tid}: {gate_err}", file=sys.stderr)
continue
if not ok:
failed.append(tid)
print(f"cannot complete {tid} (unknown id or terminal state)", file=sys.stderr)
else:
Expand Down
Loading