Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onepassword_item_share Resource Type #199

Closed
wants to merge 2 commits into from
Closed

Conversation

joraff
Copy link

@joraff joraff commented Oct 11, 2024

This PR adds item sharing as a managed resource!

Sharing an item is only supported by the 1Password CLI, and therefore, only by service and user accounts. Attempting to create this resource when using 1Password Connect Server will result in an error.

Copy link
Contributor

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@joraff
Copy link
Author

joraff commented Oct 11, 2024

Commits were signed, but I didn't have my signing key in GitHub - fixed!

P.S. - I realize this isn't that valuable of a resource type to have since it isn't actually managing anything (read, update, and delete methods do nothing - by design), but I had a use for it. I debated for a hot minute between doing this and wrapping op item share in a null_resource, and decided to do this because I wanted the practice writing in go and plugin code! And it's prettier.

@joraff joraff marked this pull request as ready for review October 11, 2024 03:13
@joraff
Copy link
Author

joraff commented Oct 21, 2024

Can a maintainer re-run the signed commits workflow? Should show as all signed now. Also, some feedback on the feature enhancement proposal?

@joraff
Copy link
Author

joraff commented Nov 14, 2024

Going to open a new PR to clear the workflow failure

@joraff joraff closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant