Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image crate to 0.24 #75

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Update image crate to 0.24 #75

merged 5 commits into from
Sep 21, 2022

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Aug 19, 2022

No description provided.

@emilk emilk mentioned this pull request Aug 19, 2022
Merged
2 tasks
@emilk emilk mentioned this pull request Sep 2, 2022
Open
Jasper-Bekkers
Jasper-Bekkers approved these changes Sep 2, 2022
View reviewed changes
Copy link

@Jasper-Bekkers Jasper-Bekkers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran into this as well, a new release of arboard with this PR would help us quite a bit since we're now sitting on this fork instead.

@complexspaces
Copy link
Collaborator

Hey everyone, sorry for the delay reviewing this. I've been on leave for a few weeks.

It looks like the API of image changed in 0.24 and its breaking the Linux builds. Do you have access to a Linux system to look at the problem?

@emilk
Copy link
Contributor Author

emilk commented Sep 17, 2022

@complexspaces I don't, but I tried my best anyway :)

@complexspaces
Copy link
Collaborator

complexspaces commented Sep 19, 2022 •
edited
Loading

Hey again @emilk. I decided to release this one on its own (I released 3.0 without it because we're stuck on image 0.23 internally at work) and sadly got into a state of conflict. I fixed it locally but I wasn't able to update the PR branch. It's a pretty easy conflict, num-iter just needs removed from the lockfile. I'm really sorry for the trouble again.

As soon as the branch has the conflicts resolved, I'll merge this and release a version for you with the update :)

@emilk
Copy link
Contributor Author

emilk commented Sep 20, 2022

Done!

@complexspaces complexspaces merged commit a33cea4 into 1Password:master Sep 21, 2022
@complexspaces
Copy link
Collaborator

This is now released as 3.1.0. Thanks for working with me on this one.

@emilk
Copy link
Contributor Author

emilk commented Sep 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@complexspaces complexspaces complexspaces approved these changes

@Jasper-Bekkers Jasper-Bekkers Jasper-Bekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilk @complexspaces @Jasper-Bekkers