Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 容器仓库配置地址，增加有效性校 #5664

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: 容器仓库配置地址，增加有效性校 #5664

merged 1 commit into from
Jul 3, 2024

Conversation

john1298308460
Copy link
Contributor

@john1298308460 john1298308460 commented Jul 3, 2024 •
edited
Loading

Refs #4542

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 3, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@1Panel-bot 1Panel-bot added the dev label Jul 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wanghe-fit2cloud
wanghe-fit2cloud reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Jul 3, 2024
@wanghe-fit2cloud
Copy link
Member

/approve

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved label Jul 3, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8301382 into dev Jul 3, 2024
5 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@urlwarn branch July 3, 2024 10:05
KaySar12 pushed a commit to KaySar12/1Panel that referenced this pull request Oct 17, 2024
@john1298308460
feat: 容器仓库配置地址，增加有效性校 (1Panel-dev#5664)
59d8554 
Refs 1Panel-dev#4542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghe-fit2cloud wanghe-fit2cloud wanghe-fit2cloud left review comments

@wangdan-fit2cloud wangdan-fit2cloud Awaiting requested review from wangdan-fit2cloud

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

@wanghe-fit2cloud wanghe-fit2cloud

Labels
approved dev do-not-merge/release-note-label-needed lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john1298308460 @wanghe-fit2cloud @1Panel-bot @JohnZjh1994