[Perf] Audit and recover DFlash2 native prefill routes - #586
Merged
yangzhuxinyzx merged 4 commits intoSep 10, 2026
Merged
Conversation
Assisted-by: Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Assisted-by: Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Assisted-by: Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Assisted-by: Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
yangzhuxinyzx
marked this pull request as ready for review
September 10, 2026 08:59
yangzhuxinyzx
added a commit
that referenced
this pull request
Sep 10, 2026
User-authorized main integration after prerequisites #586 and #587. Preserve explicit opt-in activation and unmet 7-ms attention / 22-ms round targets. Combined-tree tests:26 passed,1 skipped; scoped pre-commit passed. Assisted-by: Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restore and document the missing native prefill routes in the frozen QUASAR + DFlash2 performance launch. The service lacked the FA2 sidecar and forced serial GDN prefill. Loading the matching FA2 library and selecting the existing original FlashQLA GDN route recovers 64K prefill to 3651 tokens/s and 128K to 3015 tokens/s. This PR adds four-rank native-library/configuration checks, verified cold-prefill counters and separate q8/late-prefill tracing. It does not change production kernels or serving defaults.
This scope does not duplicate #548 (native prefill implementation), #556 (the accepted verification optimizations), #566 (TP2), or #561 (shared weights).
Test Plan
Serving source stays frozen at a7cc5ae. Preserve physical GPUs 4–7, TP4/B1/q8, 4096 prefill budget, 262144 total capacity, E4M3 target KV, FP32 logits/state, weights, sampling and CUDA graphs. Add the explicitly selected FA2 sidecar from #548 with matching source hashes, then select original GDN prefill. Measurements stop at 128K at the user's request.
Reset prefix caches per length and require computed-prefill tokens to equal full input length. Record actual FA2 bridge hits on four ranks and the original-GDN runtime log hit. Keep unprofiled timings separate from graph-node traces. Use one cold request and three repeated 256-token latency windows with EOS honored. These bounded probes do not establish dataset quality or three-startup performance acceptance.
Test Result
Harness base: 80545c0. Native hashes, report names, failed paths and remaining gates are recorded in docs/design/sm70_dflash2_context_cost_20260909.md. The owned service is stopped; 256K requests remain held.
AI assistance was used for diagnostics and reporting.
Assisted-by: Codex
Main integration
The user explicitly requested merging the current DFlash2 optimization work to main on 2026-09-10. Merge order: #586 → #587 → #589. The combined tree against main
0a0d4d6754f553ab00307eac807e9b5963b58b37merges cleanly and passesCUDA_VISIBLE_DEVICES='' .venv/bin/python -m pytest -q tests/v1/worker/test_sm70_long_attention_graphs.py tests/kernels/core/test_sm70_dflash2_state_audit.py(26 passed, 1 skipped) and scoped pre-commit. This merge preserves explicit opt-in switches and does not assert the unfinished 7-ms attention or 22-ms round targets. It adds no default activation or new service admission.