Skip to content

[Bugfix][MTP] Integrate safe YaRN context inheritance (#410) - #540

Merged
yangzhuxinyzx merged 6 commits into
mainfrom
codex/v100-sep07-mtp-yarn-audit-20260907-031538
Sep 7, 2026
Merged

yangzhuxinyzx merged 6 commits into
mainfrom
codex/v100-sep07-mtp-yarn-audit-20260907-031538

Conversation

@yangzhuxinyzx

Copy link
Copy Markdown
Contributor

Purpose

Integrate #410 against latest public main 586026e7c575febd6f2f321bf7df17bbbb7e98fe, preserving its original commits. Inherit validated explicit target YaRN for an extended native MTP drafter, and eliminate changing-argument warning spam above its configured cap.

Audit repairs

  • Current Transformers 5.12.1 rejected the old unit-test fixtures before vLLM validation (5 failed / 2 passed). Initialize complete config fixtures first and then inject deliberately malformed values to test vLLM's own guards.
  • Repair missing-value mypy errors; reject numeric-conversion overflow and non-finite scaled limits with a configuration ValueError.
  • Preserve existing matching checkpoint RoPE scaling, including linear and YaRN, when the engine-derived context limit already covers the request. The new target-inheritance restriction must not reject previously supported scaled checkpoints.
  • Add missing-field, finite/overflow, target-ceiling, unrelated-drafter and existing-RoPE regression coverage.

Test Plan / Result

19 targeted CPU/meta configuration tests passed, including the real ModelConfig length derivation helper for existing scaling. Scoped pre-commit including mypy passed. No model download, server startup, full E2E or new GPU benchmark. Await fresh GitHub integration CI before ready/merge.

Boundaries

This is configuration and warning behavior, not a new attention kernel or new numerical approximation. The original PR's historical 564K MTP service evidence is retained but is not a fresh latest-main benchmark or proof of 1M output quality. Only explicitly requested extended native MTP configuration inherits new scaling; unrelated drafts and unextended contexts remain unchanged.

Ownership / evidence

Owned worktree /home/ymzx/桌面/1cat-vllm/worktrees/v100-sep07-mtp-yarn-audit-20260907-031538. Logs /tmp/1cat-sep07-yarn-cpu.log (original failures), /tmp/1cat-sep07-yarn-cpu4.log (19 passed), /tmp/1cat-sep07-yarn-commit4.log (static gates). Canonical dirty checkout untouched.

ga-it and others added 6 commits August 28, 2026 20:26
…audit-20260907-031538

Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Integrate #410 on current main. Keep malformed test inputs out of Transformers constructor validation and test finite limits, target ceilings and unrelated-drafter isolation.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
…yarn-audit-20260907-031538

Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Only inherit target YaRN when existing draft scaling does not already cover the request; retain valid linear and checkpoint YaRN configurations.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
…yarn-audit-20260907-031538

Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
@yangzhuxinyzx
yangzhuxinyzx marked this pull request as ready for review September 7, 2026 03:29
@yangzhuxinyzx
yangzhuxinyzx merged commit 2946e0e into main Sep 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants