[Benchmark][SM70] Audit GLM reasoning completion - #402
Merged
yangzhuxinyzx merged 1 commit intoSep 5, 2026
Merged
Conversation
Assisted-by: OpenAI Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Contributor
Author
|
最新 main 审计发现空输出漏洞:_quality_metrics("", [], finish_reason="stop") 返回 passed=True。维护者修复 #499 保留本 PR 的 reasoning-effort 与历史质量证据,新增空字符串/纯空白回归,并按已确定的产品标准将 greedy token identity 留作诊断而非质量硬门槛。8 项测试和修改文件 pre-commit 已通过,待最终 CI 后合入。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the SM70 quality/speed matrix understand GLM-5.3's real chat-template control and reject outputs that exhaust their budget inside reasoning without a visible final answer. Record the stabilized TP4/PP2 decode, prefill, KV-capacity, and task-level quality evidence.
Base SHA:
62ad1e02693f4c857f3b7547cef1860ee54e8053Head SHA:
70f1d4fb3cWhy This Is Not A Duplicate
An open-PR search for quality-audit, reasoning-effort, and GLM matrix work returned no match. Runtime PRs #392 and #396 provide the exact KDA kernel; this PR changes only the audit harness, focused tests, and retained acceptance record.
Implementation
--reasoning-effort={low,high,max}and preserve it through tokenizer fallbacks and matrix worker subprocesses.Test Plan And Result
pytest -q --confcutdir=tests/benchmarks tests/benchmarks/test_sm70_quality_speed_matrix.py:6 passed.git diff --check: pass.enable_thinking=true/falseare identical Max prompts;reasoning_effort=low/high/maxrenders the intended mode.Retained GPU Evidence
Contract: GLM-5.3-Flash-NVFP4, modelopt NVFP4 MoE plus FP16 non-expert weights, FP8 E4M3 KV, TP4/PP2 on eight V100 32GB, B1, no MTP, 1K input / 256 output, full decode CUDA Graph.
53.013085 / 53.018516 / 53.017527 token/s; mean53.016376 token/s, mean TPOT18.862097 ms.3.845156 / 3.851318 / 3.850663 s; mean3.849045 sor266.039984 token/s.2.94 GiBavailable on the limiting worker,255,122cache tokens,62.29xat 4,096 tokens.2/2).Artifacts:
/data/minimax-h3/task-cache/glm53-nvfp4-sm70-20260827/.Risk
This does not claim unconditional default-Max model quality: production must pass
reasoning_effort=lowfor concise code/structured work or allocate a sufficiently large Max reasoning budget. No runtime CUDA, model, attention, quantization, or KV-cache source is changed by this PR.AI Assistance
AI assistance was used to implement and test this change. The human submitter must review every changed line and be able to defend the result before promotion from Draft.