[Bench][SM70] Add DFlash2 selector alignment diagnostics - #291
Merged
yangzhuxinyzx merged 5 commits intoAug 25, 2026
Merged
Conversation
Assisted-by: OpenAI Codex Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Add the fixed quality harness to the owned worktree, harden optional-extension provenance reporting, and report held-out position-wise selector calibration headroom. Assisted-by: OpenAI Codex <codex@openai.com> Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Add a lossless greedy-mixture proposal family to the fixed selector alignment audit and cover its exact probability transform. Assisted-by: OpenAI Codex <codex@openai.com> Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
Contributor
Author
|
审计结论:当前不进入 main,保留研究分支后关闭。 这是诊断/R&D 工具集,不是已经闭环的优化:PR 明确写明 GPU trace、端到端 acceptance、性能与 +0.5 tokens/round 结果全部 pending。它新增约 1,396 行,包括运行时 shadow lattice、同步 GPU->CPU dump、两套 benchmark/analyzer 与固定质量 harness,但没有真实 dump 上的 held-out 结果,更没有候选配置进入同条件 A/B。主线也已经有通用 VLLM_SPEC_DUMP_ALIGNMENT 基础设施,因此仅把 DFlash2 专用采集器并入生产路径,会先增加维护面而没有推进实现决策。 可拆分审计未发现应单独合并的 bugfix:所有 runtime 变更都只服务于该诊断,默认关闭本身不是性能/质量证据。最优后续是从该分支完成真实 trace -> held-out survivor -> exact-q 实现 -> V100 延迟/接受率/质量门禁,再以小型实现 PR 提交;离线分析脚本可留作该实验分支工具。当前关闭不会删除提交或证据。 |
Record the active trace-first optimization plan and promotion gates. This is explicitly a planning record, not a 17 ms performance claim. Signed-off-by: 1Cat Audit Agent <audit@1cat.ai>
…1-20260825-160720 Signed-off-by: yangzhuxinyzx <153831768+yangzhuxinyzx@users.noreply.github.com>
yangzhuxinyzx
marked this pull request as ready for review
August 25, 2026 17:31
Contributor
Author
|
源码审计完成:该变更仅增加显式启用、默认关闭的 DFlash2 selector alignment 诊断与分析工具,不改变默认推理热路径。专项测试 78 passed / 12 skipped;PR 改动文件的 pre-commit 全部通过。GitHub 全仓 pre-commit 失败来自 227 个历史基线文件被格式化,和本 PR 的 8 个文件重叠为 0,因此判定为非阻断基线噪声。 |
yangzhuxinyzx
deleted the
codex/v100-v100-dflash2-acceptance-rd-20260825-113155
branch
August 26, 2026 07:55
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add explicit, default-off DFlash2 selector alignment capture and an offline analyzer for exact proposal-distribution research. The tooling records the fixed top16 IDs, unary logits, the 7x16x16 selector lattice, realized q rows, target top20 rows, and strict rejection outcomes only when VLLM_SPEC_DUMP_ALIGNMENT is enabled.
This PR does not change the production proposal policy and makes no acceptance or performance claim. It provides the evidence path needed to develop a later default-on optimization.
Safety
Test Result