Skip to content

Ложное срабатывание проверки типа #1048 #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ложное срабатывание проверки типа #1048 #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...8codestyle.bsl/src/com/e1c/v8codestyle/bsl/comment/check/AbstractDocCommentTypeCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ protected boolean isCanSkipEmptyTextPart(IDescriptionPart part, int lastLine)
{
String text = ((TextPart)part).getText();
if (text != null && (".".equals(text.trim()) //$NON-NLS-1$
|| IBslCommentToken.TYPE_SECTION_DASH.equals(text.trim()) && lastLine != part.getLineNumber()))
|| IBslCommentToken.TYPE_SECTION_DASH.equals(text.trim()) && lastLine != part.getLineNumber())
|| text != null && text.startsWith("@skip-check")) //$NON-NLS-1$
Comment on lines +107 to +108
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь проблеме не в проверке а в том, поддерживает ли модель данных док.коммента и расчет типов ЕДТ по модели поддерживает такую ситуацию? тип по ссылке считается корректно, если есть TextPart после ссылки?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Модель не поддерживает расчет типа по ссылке, так что видимо не ложное срабатывание

{
return true;
}
Expand Down