Merged
Conversation
jmhooper
requested review from
Sgtpluck,
jmax-gsa,
solipet,
theabrad and
zachmargolis
Sgtpluck
reviewed
Feb 28, 2024
|
|
||
| context 'context that contains a VTR substring but is not a VTR' do | ||
| let(:authn_context_classref) do | ||
| fake_vtr = 'Not a VTR but does contain LetT3.Rs and Nu.Mb.Ers' |
Sgtpluck
approved these changes
Feb 28, 2024
Sgtpluck
left a comment
Sgtpluck
left a comment
There was a problem hiding this comment.
oh good catch! have a small question about whether explicitly testing urn:gov:gsa:ac:classes:sp:PasswordProtectedTransport:duo is worthwhile
A previous commit added a regex that looked like this to detect a VTR: ``` [A-Z][a-z0-9](\.[A-Z][a-z0-9])* ``` That turned out to be a regex that _also_ matches on this valid authn context: ``` urn:gov:gsa:ac:classes:sp:PasswordProtectedTransport:duo ``` This commit modifies the regex so it must match on the entire string to be valid to fix this issue.
jmhooper
force-pushed
the
jmhooper-stricter-vtr-validation
branch
from
43d675b to
f7dd59d
Compare
jmhooper
added a commit
to 18F/identity-idp
that referenced
this pull request
Mar 4, 2024
This commit enables SAML service providers to make requests using vectors of trust. Vectors of trust support has been built into OIDC in previous commits and much of the work to support this feature was done there. This commit usee the changes in 18F/saml_idp#91 to capture the VTR and store it in the service provider request (and eventually `sp_session`). This is done in the `FederateProtocols::Saml` model similar to the approach for OIDC. This commit modifies `SamlRequestValidator` to validate VTRs alongside validations that exist today for `AuthnContextClassref`s. The `Vot::Parser` is used here to validate the format of VoTs. The `SamlRequestValidator` validates that an SP is allowed to make requests with identity proofing if it is requested. Finally the `SamlRequestValidator` will also fail if the vector or trust feature is not available in the environment The logic for biometric comparison was added to `SamlIdpController` to support the `Pb` component-value that can be used there now. Users are prompted to go through proofing with a selfie if it is required. This includes users who have proofed without a selfie.. If the biometric comparison feature is not enabled for the environment and it is requested with the `Pb` component value `SamlIdpController` will render a 406 similar to the `OpenidConnect::AuthorizationController`. changelog: Internal, SAML, VTR support was added to SAML
jmhooper
added a commit
to 18F/identity-idp
that referenced
this pull request
Mar 5, 2024
This commit enables SAML service providers to make requests using vectors of trust. Vectors of trust support has been built into OIDC in previous commits and much of the work to support this feature was done there. This commit use the changes in 18F/saml_idp#91 to capture the VTR and store it in the service provider request (and eventually `sp_session`). This is done in the `FederateProtocols::Saml` model similar to the approach for OIDC. This commit modifies `SamlRequestValidator` to validate VTRs alongside validations that exist today for `AuthnContextClassref`s. The `Vot::Parser` is used here to validate the format of VoTs. The `SamlRequestValidator` validates that an SP is allowed to make requests with identity proofing if it is requested. Finally the `SamlRequestValidator` will also fail if the vector or trust feature is not available in the environment The logic for biometric comparison was added to `SamlIdpController` to support the `Pb` component-value that can be used there now. Users are prompted to go through proofing with a selfie if it is required. This includes users who have proofed without a selfie.. If the biometric comparison feature is not enabled for the environment and it is requested with the `Pb` component value `SamlIdpController` will render a 406 similar to the `OpenidConnect::AuthorizationController`. changelog: Internal, SAML, VTR support was added to SAML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous commit added a regex that looked like this to detect a VTR:
That turned out to be a regex that also matches on this valid authn context:
This commit modifies the regex so it must match on the entire string to be valid to fix this issue.