Add error for wrong SignatureAlgorithm#124
Merged
Conversation
Sgtpluck
commented
Nov 7, 2024
| request['ForceAuthn'] == 'true' | ||
| end | ||
|
|
||
| def requested_authn_context |
Author
There was a problem hiding this comment.
this method is unused in this gem and in the IdP
… signing algorithm
Sgtpluck
force-pushed
the
dmm/add-sig-alg-error
branch
from
55163b5 to
5db679f
Compare
lmgeorge
reviewed
Nov 7, 2024
lmgeorge
reviewed
Nov 7, 2024
lmgeorge
reviewed
Nov 7, 2024
lmgeorge
reviewed
Nov 7, 2024
spec/support/certificate_helpers.rb
Outdated
| "\n-----END CERTIFICATE-----\n" | ||
| end | ||
|
|
||
| def xml_cert_text(cert) |
There was a problem hiding this comment.
(suggestion, non-blocking): Consider renaming this method remove_cert_boundaries
Author
There was a problem hiding this comment.
thank you for helping me with my terrible naming, updated in 8658a88
lmgeorge
approved these changes
Nov 7, 2024
lmgeorge
left a comment
lmgeorge
left a comment
There was a problem hiding this comment.
A few non-blocking suggestions, but overall looks great!
zachmargolis
reviewed
Nov 7, 2024
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a SAML request to Login.gov is signed, it is only considered valid if it has been signed using a SignatureAlgorithm of SHA256. This is the most consistent error we see, but we don't return a specific error for it.
While attempting to make this change, I got frustrated at how hard it was to create meaningful tests because our test suite relies heavily on bespoke XML that is hard to read, understand, or easily change.
This change: