Conversation
Gemfile
Outdated
| ruby '~> 3.2' | ||
|
|
||
| gem 'rails', '~> 7.0.8' | ||
| gem 'rails', '~> 7.1.3.3' |
Contributor
There was a problem hiding this comment.
Do we want to upgrade from 7.0 to 7.1 or just upgrade the patch version on the 7.0 series?
Contributor
There was a problem hiding this comment.
Sorry, I meant whether going from 7.0 to 7.1 was intentional since it usually includes some other work described in the upgrade guide.
As an example, the IDP required a few other changes: 18F/identity-idp#9333
f868179 to
c7771f7
Compare
mitchellhenke
approved these changes
Jun 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Rails to 7.1.3.3 to fix a security issue.
test:
Check that it spins up properly and
make lintruns without issue