Skip to content

upgrade Rails to 7.1.3.3#463

Merged
mdiarra3 merged 1 commit intomainfrom
update-rails-security-fix
Jun 3, 2024
Merged

upgrade Rails to 7.1.3.3#463
mdiarra3 merged 1 commit intomainfrom
update-rails-security-fix

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Jun 3, 2024

Update Rails to 7.1.3.3 to fix a security issue.

test:

Check that it spins up properly and make lint runs without issue

Gemfile Outdated
ruby '~> 3.2'

gem 'rails', '~> 7.0.8'
gem 'rails', '~> 7.1.3.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to upgrade from 7.0 to 7.1 or just upgrade the patch version on the 7.0 series?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im fine with 7.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant whether going from 7.0 to 7.1 was intentional since it usually includes some other work described in the upgrade guide.

As an example, the IDP required a few other changes: 18F/identity-idp#9333

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@mdiarra3 mdiarra3 force-pushed the update-rails-security-fix branch from f868179 to c7771f7 Compare June 3, 2024 14:54
@mdiarra3 mdiarra3 merged commit 07e6327 into main Jun 3, 2024
@mdiarra3 mdiarra3 deleted the update-rails-security-fix branch June 3, 2024 15:41
@aduth aduth mentioned this pull request Jun 3, 2024
@mitchellhenke mitchellhenke restored the update-rails-security-fix branch June 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants