Skip to content

Remove unused OIDs (LG-12952)#461

Merged
mdiarra3 merged 6 commits intomainfrom
LG-12952-implement-removal-oids
Jun 3, 2024
Merged

Remove unused OIDs (LG-12952)#461
mdiarra3 merged 6 commits intomainfrom
LG-12952-implement-removal-oids

Conversation

@mdiarra3
Copy link
Contributor

🎫 Ticket

LG-12952

🛠 Summary of changes

Remove unused OIDs

@mdiarra3 mdiarra3 requested a review from a team May 24, 2024 16:11
@mitchellhenke mitchellhenke changed the title LG-12952 Remove unused OIDs (LG-12952) May 24, 2024
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

valid: false,
error: 'self-signed cert',
openssl_valid: false,
openssl_errors: 'error 18 at 0 depth lookup: self signed certificate, error 26 at 0 depth lookup: unsupported certificate purpose',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is for self-signed certificates, so I'm surprised that it needs to have the self-signed part of the error message removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea me too. Gonna check on this more

@mdiarra3 mdiarra3 merged commit 68cd9ea into main Jun 3, 2024
@mdiarra3 mdiarra3 deleted the LG-12952-implement-removal-oids branch June 3, 2024 16:18
@aduth aduth mentioned this pull request Jun 3, 2024
@mitchellhenke mitchellhenke restored the LG-12952-implement-removal-oids branch June 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants